Fix all the deprecated-warnings and upgrade django to 1.11 #664

sks444 · 2020-04-05T10:24:17Z

Toward #611

Note: This PR has changes incompatible with Python 2.7 and is a part of the task involving Django 2.2 upgrade

Upgrading django-pagedown to 1.0.6 because the latest version doesn't support Django 1.11, will be upgrading to latest while moving to Django 2.0
Fix AttributeError: type object 'RadioSelect' has no attribute 'renderer': 1
Use django-markdown-app as django_markdown is not maintained.
Upgrade djangorestframework to latest version which removes the support of filters, so update django-filters to latest and made changes according to the requirements: 1
Upgrade celery to latest version
Droping use of django-uuidfield as Django has it's own UUIDfield: need to figure out a way to handle the migration
Upgrade django-bootstrap3==11.0.0, needs to upgraded to latest while moving to Django 2
core.context_processors is moved to template.context_processors
Use user.is_authenticated as property

After these changes, only deprecated warnings remaining is related to Django which I think will vanish when we finally move to Django 2.0

coveralls · 2020-04-05T10:26:13Z

Coverage increased (+0.03%) to 67.292% when pulling e70b6b2 on sks444:fix-all-deprecated-warnings into 49af450 on pythonindia:master.

pradyunsg · 2020-04-05T13:14:42Z

@sks444 If you could make atomic commits, that'd make reviewing your PR (as well as iterating on them later) much easier! ^>^

sks444 · 2020-04-08T19:31:43Z

junction/devices/models.py

@@ -14,7 +13,7 @@ def expiry_time(expiry_mins=60):


 class Device(TimeAuditModel):
-    uuid = UUIDField(version=1, hyphenate=True, unique=True, db_index=True)
+    uuid = models.UUIDField(default=uuid.uuid4, editable=False, unique=True)


Okay, so we'll move to Django's UUIDField and figure out a way to migrate old data to this.

@pradyunsg would appreciate some help around this.

So I replaced the django-uuidfield with Django's UUIDField which created a new migration. But the old migration of this field still exists which will throw error as the uuidfield package doesn't exist anymore. What do you think would be the best way to handle this scenario, currently I am commenting out the lines which uses that package in the old migration.

Also, how do I migrate the new migrations, as uuid column for this model already exists. And while doing so how do I make sure that the old data of that field is migrated to the new one.

I looked it up online but couldn't find anything on how to tackle this problem, some guidance/hints would be great. :)

Okay, so this is resolved, as I got to know that it's better to edit the old migration files to pretend that the field was always a models.UUIDField. That way we won't require any migration. Checkout the answer at Django Forum for more clarification.

sks444 · 2020-04-08T19:42:07Z

@sks444 If you could make atomic commits, that'd make reviewing your PR (as well as iterating on them later) much easier! ^>^

Yes, thank you for the suggestion @pradyunsg , I will try to do atomic commits. Actually in this case, when I upgrade django, it starts breaking few other things, so all those fixes should go in one commit right? Or should I have a separate commit for each of the fix? But they are dependent on only one thing, i.e. upgrading django.

pradyunsg · 2020-04-08T23:00:52Z

I think a separate commit per fix would be better.

sks444 · 2020-04-09T22:16:42Z

I think this is ready for review now. :)

ananyo2012 · 2020-04-10T07:35:31Z

@sks444 Why are new migrations created for conferences and proposals ? There is no change in conference or proposal model.

ananyo2012 · 2020-04-10T07:42:40Z

Also can you rebase your changes on the latest master and solve the linting errors.

sks444 · 2020-04-10T14:04:53Z

@sks444 Why are new migrations created for conferences and proposals ? There is no change in conference or proposal model.

@ananyo2012, That is coming from the simple_history package upgrade as we are using simple_history models for conference and proposal models.

I moved the migration files to simple_history package upgrade commit so that it would be reasonable.

sks444 · 2020-04-10T14:21:57Z

So everything seems to be running perfectly, tests are passing and I am interacting with the UI and checking if these changes break something. But as I don't have much experience with the project I might miss few features. @pradyunsg, @ananyo2012, would be great if you could help me with the same. :)

pradyunsg · 2020-04-15T11:42:27Z

Do your thing Travis CI.

ananyo2012 · 2020-05-02T15:49:41Z

@sks444 Can you rebase your changes over the latest master ?

sks444 · 2020-05-06T07:17:46Z

Rebased @ananyo2012

palnabarun · 2020-05-06T08:30:17Z

Note: Putting a hold on the merge until the upgrade compatibility is tested

palnabarun · 2020-05-06T08:31:13Z

@sks444 The CI is failing due to conflicting migrations. Can you please check?

sks444 · 2020-05-07T06:47:05Z

Resolved the migration issue @palnabarun

pradyunsg · 2020-05-07T10:48:28Z

* Upgrade djangorestframework to latest version

This isn't supported on Python 2.

@pythonindia/pycon-india-2020-junction Do we care about Python 2 support? If not, let's drop it?

palnabarun · 2020-05-07T11:22:45Z

@sks444 Thank you for resolving that.

@pradyunsg We do care about Python 2 at the moment.

onlinejudge95 · 2020-06-06T13:11:57Z

@sks444 need your input in #687

sks444 · 2020-06-06T16:04:25Z

@onlinejudge95 we can not move directly to Django 2 without merging this pr as it would break a lot of things.

I have made all the changes here which are required to upgrade to Django 1.11. Although I have tested this on my system, it would very helpful if you could also verify this on yours. So that we could go ahead and merge this and then we can try upgrading to Django 2 and see what breaks.

onlinejudge95 · 2020-06-06T16:06:36Z

@sks444 on it

Even I was bumping the versions incrementally it failed for 1.10 for me due to obsolete dependencies.

palnabarun · 2020-06-06T18:58:27Z

@sks444 -- can you please change the target of your changes to django-2.2 branch? We are starting to merge Django upgrade related changes to that branch.

sks444 · 2020-06-07T07:37:04Z

Done @palnabarun

onlinejudge95 · 2020-06-09T08:44:50Z

@sks444 @palnabarun Django REST framework has dropped support for Python2.7 link. I doubt we will be able to pass the installation steps in Travis build due to this.

Proposing to drop support for Python2.7, what do you say guys?

ananyo2012 · 2020-06-10T03:59:37Z

We will be dropping Python 2.7 support and remove it from before this is merged

…

On Tue, 9 Jun, 2020, 2:15 PM onlinejudge95, ***@***.***> wrote: @sks444 <https://github.com/sks444> @palnabarun <https://github.com/palnabarun> Django REST framework has dropped support for Python2.7 link <https://www.django-rest-framework.org/#requirements>. I doubt we will be able to pass the installation steps in Travis build due to this. Proposing to drop support for Python2.7, what do you say guys? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#664 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQAER3KYLKZQMLQXUN5OSDRVXZBDANCNFSM4MASPRZQ> .

sks444 commented Apr 8, 2020

View reviewed changes

sks444 force-pushed the fix-all-deprecated-warnings branch 2 times, most recently from ddba3a4 to 5707742 Compare April 9, 2020 22:07

sks444 marked this pull request as ready for review April 9, 2020 22:13

ananyo2012 closed this Apr 10, 2020

ananyo2012 reopened this Apr 10, 2020

sks444 force-pushed the fix-all-deprecated-warnings branch from 5707742 to 035282b Compare April 10, 2020 13:59

sks444 force-pushed the fix-all-deprecated-warnings branch 2 times, most recently from d527886 to e70b6b2 Compare April 10, 2020 15:55

pradyunsg closed this Apr 15, 2020

pradyunsg reopened this Apr 15, 2020

sks444 force-pushed the fix-all-deprecated-warnings branch from e70b6b2 to b8dddb9 Compare May 6, 2020 07:17

sks444 force-pushed the fix-all-deprecated-warnings branch from b8dddb9 to ad3aea3 Compare May 7, 2020 06:35

palnabarun mentioned this pull request Jun 6, 2020

Update Django to 2.2 #687

Draft

1 task

sks444 added 15 commits June 7, 2020 13:02

Bump Django version to 1.11.17

b5a0598

Use Django's UUIDField instead of uuidfield package

aae29e6

Bump django-pagedown version to 1.0.6

457b00d

Fix RadioSelect object has no attribute renderer

e6dcbf4

Use django-markdown-app as django-markdown is not maintained

60ee397

Bump djangorestframework to 3.11.0 and django-filter to 2.2.0

00debde

Bump celery version to 4.4.2

eaaf467

Bump django-simple-history version to 2.8.0

51129d7

Bump django-bootstrap3 to 11.0.0

7f6c38f

Bump django-bootstrap-breadcrumbs version to 0.9.2

414ad27

Use template context_processors instead of core

ff2a499

Use user.is_authenticated as property

207087d

Bump pytest-django version to 3.9.0

cd19469

Lint the code

e3b06cf

Fix ticket model __str__ method

8d78d59

sks444 force-pushed the fix-all-deprecated-warnings branch from ad3aea3 to 8d78d59 Compare June 7, 2020 07:32

sks444 changed the base branch from master to django-2.2 June 7, 2020 07:35

dishantsethi mentioned this pull request Jun 7, 2020

Upgrade Django to 2.2 LTS #611

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix all the deprecated-warnings and upgrade django to 1.11 #664

Fix all the deprecated-warnings and upgrade django to 1.11 #664

sks444 commented Apr 5, 2020 •

edited by ananyo2012

Loading

coveralls commented Apr 5, 2020 •

edited

Loading

pradyunsg commented Apr 5, 2020 •

edited

Loading

sks444 Apr 8, 2020

sks444 Apr 9, 2020

sks444 commented Apr 8, 2020 •

edited

Loading

pradyunsg commented Apr 8, 2020

sks444 commented Apr 9, 2020

ananyo2012 commented Apr 10, 2020

ananyo2012 commented Apr 10, 2020

sks444 commented Apr 10, 2020

sks444 commented Apr 10, 2020

pradyunsg commented Apr 15, 2020

ananyo2012 commented May 2, 2020

sks444 commented May 6, 2020

palnabarun commented May 6, 2020

palnabarun commented May 6, 2020

sks444 commented May 7, 2020

pradyunsg commented May 7, 2020

palnabarun commented May 7, 2020

onlinejudge95 commented Jun 6, 2020

sks444 commented Jun 6, 2020

onlinejudge95 commented Jun 6, 2020 •

edited

Loading

palnabarun commented Jun 6, 2020 •

edited

Loading

sks444 commented Jun 7, 2020

onlinejudge95 commented Jun 9, 2020

ananyo2012 commented Jun 10, 2020 via email

Fix all the deprecated-warnings and upgrade django to 1.11 #664

Are you sure you want to change the base?

Fix all the deprecated-warnings and upgrade django to 1.11 #664

Conversation

sks444 commented Apr 5, 2020 • edited by ananyo2012 Loading

coveralls commented Apr 5, 2020 • edited Loading

pradyunsg commented Apr 5, 2020 • edited Loading

sks444 Apr 8, 2020

Choose a reason for hiding this comment

sks444 Apr 9, 2020

Choose a reason for hiding this comment

sks444 commented Apr 8, 2020 • edited Loading

pradyunsg commented Apr 8, 2020

sks444 commented Apr 9, 2020

ananyo2012 commented Apr 10, 2020

ananyo2012 commented Apr 10, 2020

sks444 commented Apr 10, 2020

sks444 commented Apr 10, 2020

pradyunsg commented Apr 15, 2020

ananyo2012 commented May 2, 2020

sks444 commented May 6, 2020

palnabarun commented May 6, 2020

palnabarun commented May 6, 2020

sks444 commented May 7, 2020

pradyunsg commented May 7, 2020

palnabarun commented May 7, 2020

onlinejudge95 commented Jun 6, 2020

sks444 commented Jun 6, 2020

onlinejudge95 commented Jun 6, 2020 • edited Loading

palnabarun commented Jun 6, 2020 • edited Loading

sks444 commented Jun 7, 2020

onlinejudge95 commented Jun 9, 2020

ananyo2012 commented Jun 10, 2020 via email

sks444 commented Apr 5, 2020 •

edited by ananyo2012

Loading

coveralls commented Apr 5, 2020 •

edited

Loading

pradyunsg commented Apr 5, 2020 •

edited

Loading

sks444 commented Apr 8, 2020 •

edited

Loading

onlinejudge95 commented Jun 6, 2020 •

edited

Loading

palnabarun commented Jun 6, 2020 •

edited

Loading